Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE Team][8.15][Serverless] Bulk-update a rule's custom highlighted fields #5460

Merged

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jun 21, 2024

Fixes #5090

ESS previews:

Serverless previews: (Same changes, minus API updates)

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.15.0 labels Jun 21, 2024
@nastasha-solomon nastasha-solomon self-assigned this Jun 21, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Jun 21, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review June 24, 2024 19:03
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner June 24, 2024 19:03
@nastasha-solomon nastasha-solomon requested a review from e40pud June 24, 2024 19:04
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We need to do couple small updates, happy to chaat about those.

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/rules-ui-create.mdx Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon requested a review from e40pud July 2, 2024 03:16
e40pud
e40pud previously approved these changes Jul 2, 2024
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

joepeeples
joepeeples previously approved these changes Jul 16, 2024
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few fairly optional comments, so I'll go ahead and approve in case you choose to go with things as-is. Probably the stickiest point is the question about default Security indices, the other comments just nits.

docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
docs/serverless/alerts/view-alert-details.mdx Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/rules-ui-create.mdx Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/rules-ui-management.mdx Outdated Show resolved Hide resolved
@nastasha-solomon
Copy link
Contributor Author

Verified that changes are on prod server.

@nastasha-solomon nastasha-solomon merged commit cfac679 into main Jul 23, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jul 23, 2024
…ields (#5460)

* First draft

* Fixes

* API params

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/detections/rules-ui-manage.asciidoc

* Update docs/serverless/rules/rules-ui-management.mdx

* Update docs/detections/alerts-view-details.asciidoc

* Update docs/serverless/alerts/view-alert-details.mdx

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Fixed ref

* Update docs/detections/rules-ui-manage.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/serverless/rules/rules-ui-management.mdx

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit cfac679)

# Conflicts:
#	docs/serverless/alerts/view-alert-details.mdx
#	docs/serverless/rules/rules-ui-create.mdx
#	docs/serverless/rules/rules-ui-management.mdx
nastasha-solomon added a commit that referenced this pull request Jul 23, 2024
…ghted fields (backport #5460) (#5595)

* [DE Team][8.15][Serverless] Bulk-update a rule's custom highlighted fields (#5460)

* First draft

* Fixes

* API params

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/detections/rules-ui-manage.asciidoc

* Update docs/serverless/rules/rules-ui-management.mdx

* Update docs/detections/alerts-view-details.asciidoc

* Update docs/serverless/alerts/view-alert-details.mdx

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Fixed ref

* Update docs/detections/rules-ui-manage.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/serverless/rules/rules-ui-management.mdx

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit cfac679)

# Conflicts:
#	docs/serverless/alerts/view-alert-details.mdx
#	docs/serverless/rules/rules-ui-create.mdx
#	docs/serverless/rules/rules-ui-management.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nastasha-solomon nastasha-solomon deleted the issue-5090-bulk-update-custom-highlighted-fields branch July 24, 2024 19:05
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 6, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] New feature docs - Bulk Action for Rule Custom Highlighted Fields
4 participants